Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/posix-sysinfo: Use a more Linux compatible release string #1325

Merged
merged 1 commit into from
Feb 15, 2024
Merged

lib/posix-sysinfo: Use a more Linux compatible release string #1325

merged 1 commit into from
Feb 15, 2024

Conversation

mschlumpp
Copy link
Member

Some software checks for the linux version number in the release string. Just including a '5' at the beginning is not enough in some cases. Therefore, just include some more digits.

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran the checkpatch.uk on your commit series before opening this PR;
  • Updated relevant documentation.

Base target

  • Architecture(s): N/A
  • Platform(s): N/A
  • Application(s): N/A

Additional configuration

Description of changes

@mschlumpp
lib/posix-sysinfo: Use a more Linux compatible release string
d65d50c 
Some software checks for the linux version number in the release string.
Just including a '5' at the beginning is not enough in some cases.
Therefore, just include some more digits.

Signed-off-by: Marco Schlumpp <marco@unikraft.io>
@mschlumpp mschlumpp requested a review from a team as a code owner February 14, 2024 15:56
@github-actions github-actions bot added area/lib Internal Unikraft Microlibrary lang/c Issues or PRs to do with C/C++ lib/posix-sysinfo labels Feb 14, 2024
@skuenzer skuenzer self-assigned this Feb 15, 2024
@skuenzer skuenzer self-requested a review February 15, 2024 23:03
skuenzer
skuenzer approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@skuenzer skuenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Simon Kuenzer simon@unikraft.io
Approved-by: Simon Kuenzer simon@unikraft.io

@skuenzer skuenzer changed the base branch from staging to staging-1325 February 15, 2024 23:07
@skuenzer skuenzer merged commit 0df59d1 into unikraft:staging-1325 Feb 15, 2024
12 checks passed
skuenzer pushed a commit that referenced this pull request Feb 15, 2024
@mschlumpp @skuenzer
lib/posix-sysinfo: Use a more Linux compatible release string
aa18589 
Some software checks for the linux version number in the release string.
Just including a '5' at the beginning is not enough in some cases.
Therefore, just include some more digits.

Signed-off-by: Marco Schlumpp <marco@unikraft.io>
Approved-by: Simon Kuenzer <simon@unikraft.io>
Reviewed-by: Simon Kuenzer <simon@unikraft.io>
GitHub-Closes: #1325
SerbanSo pushed a commit to SerbanSo/unikraft-ASLR that referenced this pull request Jun 16, 2024
@mschlumpp @SerbanSo
lib/posix-sysinfo: Use a more Linux compatible release string
80fcc65 
Some software checks for the linux version number in the release string.
Just including a '5' at the beginning is not enough in some cases.
Therefore, just include some more digits.

Signed-off-by: Marco Schlumpp <marco@unikraft.io>
Approved-by: Simon Kuenzer <simon@unikraft.io>
Reviewed-by: Simon Kuenzer <simon@unikraft.io>
GitHub-Closes: unikraft#1325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skuenzer skuenzer skuenzer approved these changes

Assignees

@skuenzer skuenzer

Labels
area/lib Internal Unikraft Microlibrary lang/c Issues or PRs to do with C/C++ lib/posix-sysinfo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mschlumpp @skuenzer