lib/posix-unixsocket: Fix NULL deref crash #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `unix_socket_recvfrom` would not check its `fromlen` argument before dereferencing it, even though the API allows for it to be NULL. This change fixes this oversight, eliminating a potential crash. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
github-actions
bot
added
area/lib
razvand
requested review from
razvand,
mariasfiraiala and
Mihnea0Firoiu
and removed request for
a team and
razvand
Mihnea0Firoiu
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
All good.
Reviewed-by: Mihnea Firoiu mihneafiroiu0@gmail.com
mariasfiraiala
approved these changes
Mar 16, 2024
There was a problem hiding this comment.
Looks good, thanks!
Reviewed-by: Maria Sfiraiala maria.sfiraiala@gmail.com
razvand
approved these changes
Mar 18, 2024
razvand
pushed a commit
that referenced
this pull request
Mar 18, 2024
Previously `unix_socket_recvfrom` would not check its `fromlen` argument before dereferencing it, even though the API allows for it to be NULL. This change fixes this oversight, eliminating a potential crash. Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Mihnea Firoiu <mihneafiroiu0@gmail.com> Reviewed-by: Maria Sfiraiala <maria.sfiraiala@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #1326
SerbanSo
pushed a commit
to SerbanSo/unikraft-ASLR
that referenced
this pull request
Jun 16, 2024
Previously `unix_socket_recvfrom` would not check its `fromlen` argument before dereferencing it, even though the API allows for it to be NULL. This change fixes this oversight, eliminating a potential crash. Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Mihnea Firoiu <mihneafiroiu0@gmail.com> Reviewed-by: Maria Sfiraiala <maria.sfiraiala@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: unikraft#1326
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Previously
unix_socket_recvfromwould not check itsfromlenargument before dereferencing it, even though the API allows for it to be NULL. This change fixes this oversight, eliminating a potential crash.Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
Additional configuration
Test: call
recvfrom()on a unix socket with NULL forsrc_addr.