-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support: Change PYTHONCMD
to python3
#1391
Conversation
Hi @tbunch1! Thanks for the contribution! If you are co-authoring commits with peers, please include their sign-off as part of the commit message. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @tbunch1! The changes look fine, however I have some comments regarding the commit message.
-
As @nderjung mentioned, you need to add the
Co-authored-by
tag inside the commit message. You have edited the PR message, not the commit message, so please do that. -
Add a valid email to the
Signed-off-by
tag;<92049355+tbunch1@users.noreply.github.com>
is automatically generated by GitHub so it doesn't reflect your real details (and it looks kinda bad).
That's all on my part, thanks!
Make it so that python3 is used to run scripts. Co-authored-by: Eddie Cazares <ecazares15@utexas.edu> Co-authored-by: Lindsey Bowen <lindseyb803@gmail.com> Signed-off-by: Thomas Bunch <tebunch@utexas.edu>
05a73e6
to
238186e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. The changes look good, but you all need to add a signed-off-by
tag to the commit message.
PYTHONCMD
to python3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I think the multiple Co-authored-by
is enough with at least 1 Signed-off-by
by the committer. This PR is good to go imho. Thanks!
Reviewed-by: Alexander Jung alex@unikraft.io
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Reviewed-by: Maria Sfiraiala maria.sfiraiala@gmail.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved-by: Razvan Deaconescu razvand@unikraft.io
Make it so that python3 is used to run scripts. Co-authored-by: Eddie Cazares <ecazares15@utexas.edu> Co-authored-by: Lindsey Bowen <lindseyb803@gmail.com> Signed-off-by: Thomas Bunch <tebunch@utexas.edu> Reviewed-by: Alexander Jung <alex@unikraft.io> Reviewed-by: Maria Sfiraiala <maria.sfiraiala@gmail.com> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #1391
Make it so that python3 is used to run scripts.
Prerequisite checklist
checkpatch.uk
on your commit series before opening this PR;Base target
Additional configuration
None.
Description of changes
Change makefile.patch so that python3 is used to run Python scripts.
From what we could tell all other instances of python have been replaced by python3.
GitHub-Fixes: #1006