-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib/ukfile: Add utility inlines for iovec I/O #1396
Conversation
Looks good. I see the only difference between Reviewed by: Serban Sorohan serban.sorohan@gmail.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested a couple changes, they apply for all functions not just the first one. Besides those, everything looks correct.
Reviewed by: Mihnea Popeanga popeanga.mihnea@gmail.com
This change adds a utility header providing convenience inlines for doing I/O on buffers described by struct iovec, namely: - zero out - scatter data from buffer to iov - gather data from iov into buffer Signed-off-by: Andrei Tatar <andrei@unikraft.io>
a249589
to
8408167
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good now!
Reviewed by: Mihnea Popeanga popeanga.mihnea@gmail.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition, thanks.
Reviewed-by: Eduard Vintilă eduard.vintila47@gmail.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved-by: Marco Schlumpp marco@unikraft.io
This change adds a utility header providing convenience inlines for doing I/O on buffers described by struct iovec, namely: - zero out - scatter data from buffer to iov - gather data from iov into buffer Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Eduard Vintilă <eduard.vintila47@gmail.com> Approved-by: Marco Schlumpp <marco@unikraft.io> GitHub-Closes: #1396
Description of changes
This change adds a utility header providing convenience inlines for doing I/O on buffers described by struct iovec, namely:
This code is not used by any lib or core component yet, however, the following PRs may benefit:
posix-tty
& move stdio/console files out of vfscore #1226If the above are merged before this PR, will append commits w/ patches here.
Prerequisite checklist
checkpatch.uk
on your commit series before opening this PR;Base target
x86_64
or N/A]kvm
,xen
or N/A]app-python3
or N/A]Additional configuration
N/A