plat/linuxu: Fix build errors introduced by #251 #412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix build errors introduced by unikraft#251. We add a missing bracket and remove duplicate definitions of sys_open and sys_close. Signed-off-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@upb.ro>
razvanvirtan
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
Looks good on my side!
Reviewed-by: Răzvan Vîrtan virtanrazvan@gmail.com
|
✅ Checkpatch passed Beep boop! I ran Unikraft's
|
razvand
approved these changes
Feb 19, 2022
There was a problem hiding this comment.
Nice catch. Thanks, @vladandrew
Approved-by: Razvan Deaconescu razvan.deaconescu@cs.pub.ro
razvand
added
lib/syscall_shim
bug/compile-time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix build errors introduced by #251.
We add a missing bracket and remove duplicate definitions of sys_open and
sys_close.
Signed-off-by: Vlad-Andrei Badoiu vlad_andrei.badoiu@upb.ro
Prerequisite checklist
checkpatch.plon your commit series before opening this PR;Base target
x86_64or N/A]kvm,xenor N/A]app-python3or N/A]Additional configuration
Description of changes