Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plat/common: Merge .gcc_except_tables #753

Closed

Conversation

mschlumpp
Copy link
Member

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran the checkpatch.pl on your commit series before opening this PR;
  • Updated relevant documentation.

Base target

  • Architecture(s): N/A
  • Platform(s): N/A
  • Application(s): Any application that needs exception support (most C++ applications)

Additional configuration

Description of changes

These tables are generated by GCC for exception handling. This merges the individual section together instead of keeping thousands of them separate.

These tables are generated by GCC for exception handling. This merges
the individual section together instead of keeping thousands of them
separate.

Signed-off-by: Marco Schlumpp <marco@unikraft.io>
@mschlumpp mschlumpp requested a review from a team as a code owner February 9, 2023 13:59
@unikraft-bot unikraft-bot added area/plat Unikraft Patform plat/common Common to all platforms labels Feb 9, 2023
@unikraft-bot
Copy link
Member

Checkpatch failed

Beep boop! I ran Unikraft's checkpatch.pl support script on your pull request but it encountered errors:

SHA commit checkpatch
927330a plat/common: Merge `.gcc_except_table`s

Truncated logs starting from first error 927330a:

ERROR:SPACING: space prohibited before that ':' (ctx:WxE)
#26: FILE: plat/common/include/uk/plat/common/common.lds.h:98:
+	.gcc_except_table :						\
 	                  ^

total: 1 errors, 0 warnings, 15 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/tmp/build/a53d4c5b/patches/0001-plat-common-Merge-.gcc_except_table-s.patch has style problems, please review.

NOTE: Ignored message types: ASSIGN_IN_IF FILE_PATH_CHANGES NEW_TYPEDEFS OBSOLETE

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

View complete logs | Learn more about Unikraft's coding style and contribution guidelines.

@razvand razvand assigned michpappas and unassigned nderjung Feb 10, 2023
@razvand razvand requested review from mogasergiu and removed request for a team February 10, 2023 07:13
@razvand razvand added this to the v0.13.0 (Atlas) milestone Feb 10, 2023
@razvand razvand assigned razvand and unassigned michpappas Feb 10, 2023
Copy link
Member

@craciunoiuc craciunoiuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here. Thanks!

Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io

Copy link
Member

@mogasergiu mogasergiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

Reviewed-by: Sergiu Moga sergiu.moga@protonmail.com

Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved-by: Razvan Deaconescu razvand@unikraft.io

@unikraft-bot unikraft-bot added the ci/merged Merged by CI label Apr 25, 2023
StefanJum pushed a commit to unikraft-upb/unikraft that referenced this pull request Jun 5, 2023
These tables are generated by GCC for exception handling. This merges
the individual section together instead of keeping thousands of them
separate.

Signed-off-by: Marco Schlumpp <marco@unikraft.io>
Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
Reviewed-by: Sergiu Moga <sergiu.moga@protonmail.com>
Approved-by: Razvan Deaconescu <razvand@unikraft.io>
Tested-by: Unikraft CI <monkey@unikraft.io>
GitHub-Closes: unikraft#753
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plat Unikraft Patform ci/merged Merged by CI plat/common Common to all platforms
Projects
Status: Done!
Development

Successfully merging this pull request may close these issues.

7 participants