-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plat/common: Merge .gcc_except_table
s
#753
Conversation
These tables are generated by GCC for exception handling. This merges the individual section together instead of keeping thousands of them separate. Signed-off-by: Marco Schlumpp <marco@unikraft.io>
❗ Checkpatch failed Beep boop! I ran Unikraft's
Truncated logs starting from first error 927330a:
View complete logs | Learn more about Unikraft's coding style and contribution guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
Reviewed-by: Sergiu Moga sergiu.moga@protonmail.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved-by: Razvan Deaconescu razvand@unikraft.io
These tables are generated by GCC for exception handling. This merges the individual section together instead of keeping thousands of them separate. Signed-off-by: Marco Schlumpp <marco@unikraft.io> Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io> Reviewed-by: Sergiu Moga <sergiu.moga@protonmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: unikraft#753
Prerequisite checklist
checkpatch.pl
on your commit series before opening this PR;Base target
Additional configuration
Description of changes
These tables are generated by GCC for exception handling. This merges the individual section together instead of keeping thousands of them separate.