plat/common: Ensure the .eh_frame section stays
#776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the `CONFIG_OPTIMIZE_DEADELIM` KConfig option adds the `--gc-sections` command-line flag to the linker. Because the `.eh_frame` section is not really referenced anywhere the linker will happily throw it away. The solution is to mark it with `KEEP` in the linker scripts. Signed-off-by: Marco Schlumpp <marco@unikraft.io>
unikraft-bot
added
area/plat
|
✅ Checkpatch passed Beep boop! I ran Unikraft's
|
craciunoiuc
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
The change makes sense 👍
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
mogasergiu
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Looks good.
Reviewed-by: Sergiu Moga sergiu.moga@protonmail.com
|
hi, I have a small question: do |
|
@dinhngtu The data in |
|
@nderjung 👀👀 |
nderjung
reviewed
Apr 19, 2023
nderjung
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
checkpatch.plon your commit series before opening this PR;Base target
Additional configuration
CONFIG_OPTIMIZE_DEADELIM=yDescription of changes
Using the
CONFIG_OPTIMIZE_DEADELIMKConfig option adds the--gc-sectionscommand-line flag to the linker. Because the.eh_framesection is not really referenced anywhere the linker will happily throw it away. The solution is to mark it withKEEPin the linker scripts.