query: fixed filter in with string values

unimapper · Jan 12, 2016 · 737d8f7 · 737d8f7
1 parent 9f0098e
commit 737d8f7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/Query.php b/src/Query.php
@@ -186,7 +186,7 @@ private function _formatFilter(array $filter, $or = false)
 
                             $modifier = "IN";
                             if (array_filter($value, 'is_string')) {
-                                $value = "('" . implode("','", $value) . ")";
+                                $value = "('" . implode("','", $value) . "')";
                             } else {
                                 $value = "(" . implode(",", $value) . ")";
                             }

diff --git a/tests/cases/Query.phpt b/tests/cases/Query.phpt
@@ -27,6 +27,15 @@ class QueryTest extends Tester\TestCase
         );
     }
 
+    public function testSetFilterInString()
+    {
+        $this->query->setFilter(["in" => [Filter::EQUAL => ["1", "2"]]]);
+        Assert::same(
+            "objednavka-prijata/(in IN ('1','2')).json?code-as-id=true",
+            rawurldecode($this->query->getRaw())
+        );
+    }
+
     public function testSetFilterEqual()
     {
         $this->query->setFilter(["equal" => [Filter::EQUAL=> 1]]);