Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpinning ray from requirements-dev.txt #1052

Merged
merged 12 commits into from
Dec 20, 2022
Merged

Unpinning ray from requirements-dev.txt #1052

merged 12 commits into from
Dec 20, 2022

Conversation

erichamers
Copy link
Contributor

As discussed in the discord channel, need to unpin ray in the requirements-dev.txt file.

Issue first came up because of an error (ERROR: Could not find a version that satisfies the requirement ray<=1.7.0) when running pip install -r requirements-dev.txt on mac with an apple silicon processor. The error happens because there are no available wheels for ray < 1.8.0 for apple silicon processors.

Signed-off-by: erichamers erichamers@gmail.com

@cosmicBboy
Copy link
Collaborator

hey @erichamers I think we need to remove the python_version < 3.10 qualifier.

Also, we need to run the generate_pip_deps_from_conda.py script as mentioned here

@erichamers
Copy link
Contributor Author

hey @erichamers I think we need to remove the python_version < 3.10 qualifier.

Also, we need to run the generate_pip_deps_from_conda.py script as mentioned here

Done 👍🏻

@cosmicBboy
Copy link
Collaborator

hmm, doesn't look like there's a distribution of ray that could be found (in windows at least): https://github.com/unionai-oss/pandera/actions/runs/3698662176/jobs/6265179740#step:8:137

@cosmicBboy
Copy link
Collaborator

cool, looks like we're past the ray CI/CD issue, it's the mypy stuff that I mentioned... working on this in #1056

erichamers and others added 6 commits December 15, 2022 17:35
Signed-off-by: erichamers <erichamers@gmail.com>
Signed-off-by: erichamers <erichamers@gmail.com>
Signed-off-by: erichamers <erichamers@gmail.com>
Signed-off-by: erichamers <erichamers@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 97.60% // Head: 97.60% // No change to project coverage 👍

Coverage data is based on head (badbe5a) compared to base (8ccede9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1052   +/-   ##
=======================================
  Coverage   97.60%   97.60%           
=======================================
  Files          42       42           
  Lines        4303     4303           
=======================================
  Hits         4200     4200           
  Misses        103      103           
Impacted Files Coverage Δ
pandera/schemas.py 99.43% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
@cosmicBboy
Copy link
Collaborator

okay... so I managed to patch up CI so that modin-ray tests don't run on particular python versions and OSs.

Will need to figure out how to do this in a more principled way so that pandera can only guarantee extras functionality for some set of minimum versions #1061.

@erichamers thanks for this contribution! Hopefully you'll be able to contribute to the pandera codebase after this.

@cosmicBboy cosmicBboy merged commit e2bc5b9 into unionai-oss:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants