-
-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpinning ray from requirements-dev.txt #1052
Unpinning ray from requirements-dev.txt #1052
Conversation
hey @erichamers I think we need to remove the Also, we need to run the |
Done 👍🏻 |
hmm, doesn't look like there's a distribution of ray that could be found (in windows at least): https://github.com/unionai-oss/pandera/actions/runs/3698662176/jobs/6265179740#step:8:137 |
cool, looks like we're past the ray CI/CD issue, it's the mypy stuff that I mentioned... working on this in #1056 |
Signed-off-by: erichamers <erichamers@gmail.com>
Signed-off-by: erichamers <erichamers@gmail.com>
Signed-off-by: erichamers <erichamers@gmail.com>
Signed-off-by: erichamers <erichamers@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Codecov ReportBase: 97.60% // Head: 97.60% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1052 +/- ##
=======================================
Coverage 97.60% 97.60%
=======================================
Files 42 42
Lines 4303 4303
=======================================
Hits 4200 4200
Misses 103 103
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
okay... so I managed to patch up CI so that modin-ray tests don't run on particular python versions and OSs. Will need to figure out how to do this in a more principled way so that pandera can only guarantee extras functionality for some set of minimum versions #1061. @erichamers thanks for this contribution! Hopefully you'll be able to contribute to the pandera codebase after this. |
As discussed in the discord channel, need to unpin
ray
in therequirements-dev.txt
file.Issue first came up because of an error (
ERROR: Could not find a version that satisfies the requirement ray<=1.7.0
) when runningpip install -r requirements-dev.txt
on mac with an apple silicon processor. The error happens because there are no available wheels for ray < 1.8.0 for apple silicon processors.Signed-off-by: erichamers erichamers@gmail.com