Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mypy extra unit tests, pin pandas-stubs for dev env #1056

Merged
merged 8 commits into from
Dec 15, 2022
Merged

Conversation

cosmicBboy
Copy link
Collaborator

Signed-off-by: Niels Bantilan niels.bantilan@gmail.com

This PR:

  • updates the pandera[mypy] extras tests
  • pins pandas-stubs in the dev requirements. Since this package is still under development and changes often, this will cause mypy errors in the pandera codebase, which will break CI in PRs that don't have anything to do with mypy.
  • update the pre-commit hook to apply to source directories instead of individual files.

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 97.68% // Head: 97.60% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (e4d6918) compared to base (5aa7795).
Patch coverage: 87.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1056      +/-   ##
==========================================
- Coverage   97.68%   97.60%   -0.08%     
==========================================
  Files          41       42       +1     
  Lines        4268     4303      +35     
==========================================
+ Hits         4169     4200      +31     
- Misses         99      103       +4     
Impacted Files Coverage Δ
pandera/schemas.py 99.43% <ø> (ø)
pandera/engines/pandas_engine.py 97.50% <66.66%> (ø)
pandera/checks.py 98.57% <100.00%> (ø)
pandera/decorators.py 99.51% <100.00%> (+<0.01%) ⬆️
pandera/strategies.py 98.26% <100.00%> (ø)
pandera/__init__.py 87.87% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
@cosmicBboy cosmicBboy merged commit 8ccede9 into main Dec 15, 2022
@cosmicBboy cosmicBboy deleted the fix-mypy branch December 15, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant