Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coercion): datetime tz aware into another timezone #1147

Conversation

gjeusel
Copy link
Contributor

@gjeusel gjeusel commented Mar 29, 2023

Fix a coercion bug on an already localized DateTime.
Instead of applying a failing tz_localize, just convert the timezone using tz_convert.

Introduced by #1057

Signed-off-by: Jeusel Guillaume <guillaume.jeusel@renewex.co>
@cosmicBboy
Copy link
Collaborator

hi @gjeusel thanks for the PR!

Can you update the the PR description to give a high-level overview of what bug this fixes?

@cosmicBboy cosmicBboy closed this Mar 29, 2023
@cosmicBboy cosmicBboy reopened this Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (76bfa4f) 97.45% compared to head (3685042) 97.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1147   +/-   ##
=======================================
  Coverage   97.45%   97.46%           
=======================================
  Files          67       67           
  Lines        4840     4844    +4     
=======================================
+ Hits         4717     4721    +4     
  Misses        123      123           
Impacted Files Coverage Δ
pandera/engines/pandas_engine.py 97.56% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gjeusel
Copy link
Contributor Author

gjeusel commented Mar 30, 2023

Can you update the the PR description to give a high-level overview of what bug this fixes?

Hey hey ! Like so ? Or you had something else in mind ?

@cosmicBboy
Copy link
Collaborator

thanks @gjeusel, and congrats on your first PR to pandera! 🎉

@cosmicBboy cosmicBboy merged commit a0d95c7 into unionai-oss:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants