Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coerce dt indexes and series #1057

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

cristianmatache
Copy link
Contributor

Fixes #1046

@codecov
Copy link

codecov bot commented Dec 18, 2022

Codecov Report

Base: 97.23% // Head: 97.24% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (5fd64cf) compared to base (a9f1c06).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1057   +/-   ##
=======================================
  Coverage   97.23%   97.24%           
=======================================
  Files          63       63           
  Lines        4710     4713    +3     
=======================================
+ Hits         4580     4583    +3     
  Misses        130      130           
Impacted Files Coverage Δ
pandera/engines/pandas_engine.py 97.51% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cosmicBboy
Copy link
Collaborator

hey @cristianmatache would you mind rebasing this on main? the modin test issue should go away.

@JungeAlexander
Copy link

@cristianmatache thanks for the work on this! Your solution seems to fix an issue our team and possibly other users are currently struggling with. From what I can tell, the only thing that keeps this from being merged is that you forgot to sign your commit message by adding:

Signed-off-by: Author Name authoremail@example.com

Can you please follow the detailed instructions here to sign your commit? Thanks 🙏

@cristianmatache
Copy link
Contributor Author

done, thanks for the reminder @JungeAlexander

Signed-off-by: Cristian Matache <cristianmatache@hotmail.com>
@cosmicBboy
Copy link
Collaborator

Thanks! Gonna cut the 0.14.0 release at end of Feb. thanks @cristianmatache !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coercing DateTimeIndex fails starting with Pandera v0.13.4
3 participants