feature/refactor-checks #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff makes the Check API cleaner by moving out the error handling into the schema doing the data validation instead of within the __call__ subroutine. This also standardizes the Check.__call__ signature such that it takes the dataframe or series object to be checked. This also cleans up the SeriesSchemaBase API and its subclasses, where the __call__ method takes a single argument df_or_series, which is the object to be checked.
This was referenced Jan 12, 2020
Closed
mastersplinter
approved these changes
Jan 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
+ Coverage 96.06% 96.36% +0.29%
==========================================
Files 8 9 +1
Lines 458 468 +10
==========================================
+ Hits 440 451 +11
+ Misses 18 17 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff makes the Check API cleaner by moving out the
error handling into the schema doing the data validation
instead of within the
__call__subroutine.This also standardizes the
Check.__call__signature such thatit takes the dataframe or series object to be checked.
This also cleans up the SeriesSchemaBase API and its subclasses,
where the
__call__method takes a single argument df_or_series,which is the object to be checked.