-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support typeguard < 3 for better compatability #1563
Conversation
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
Hi @cosmicBboy, thank you for your extremely fast response and solution! :) For us it would work without problems as we don't use these generic types. However if I understand correctly there is a tradeoff because this may introduce silent bugs in somebody else's code. Imagine something like this:
Another thing in the case you decide to proceed the requirements.in file, shouldn't be changed as well? setting typeguard >= 2.13.3 |
Will add a warning so that the behavior is more transparent |
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
Hi @cosmicBboy , thank you for the prompt solution. With this change, would E.g.
|
Just the |
Follow in the foodsteps of unionai-oss/pandera#1563 and relax the typeguard restriction. This allows the use of Pandera w/ typeguard 2.
This PR loosens the typeguard version dependency to support version < 3. Addresses the comment here: #1365 (comment)