Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

From yaml null index #225

Merged
merged 4 commits into from
Jun 17, 2020
Merged

From yaml null index #225

merged 4 commits into from
Jun 17, 2020

Conversation

baskervilski
Copy link
Contributor

cosmicBboy
cosmicBboy approved these changes Jun 17, 2020
View reviewed changes
Copy link
Collaborator

@cosmicBboy cosmicBboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on tests! see inline comment for minor suggestion

pandera/io.py Outdated
@@ -156,7 +156,9 @@ def _deserialize_schema(serialized_schema):
for index_component in serialized_schema["index"]
]

if len(index) == 1:
if isinstance(index, type(None)):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more concisely, this can be if index is None:

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2020 •
edited
Loading

Codecov Report

Merging #225 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #225   +/-   ##
=======================================
  Coverage   96.52%   96.52%           
=======================================
  Files          14       14           
  Lines        1236     1238    +2     
=======================================
+ Hits         1193     1195    +2     
  Misses         43       43
Impacted Files Coverage Δ
pandera/io.py 90.27% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a34f4fd...b1ca7e7. Read the comment docs.

@cosmicBboy cosmicBboy merged commit 7f9294d into unionai-oss:master Jun 17, 2020
@cosmicBboy
Copy link
Collaborator

congrats on your first contribution to this project @baskervilski! looks like you're on a roll 🙂 #226

@cosmicBboy cosmicBboy mentioned this pull request Jun 17, 2020
Closed
@baskervilski baskervilski deleted the from_yaml_null_index branch June 17, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmicBboy cosmicBboy cosmicBboy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@baskervilski @codecov-commenter @cosmicBboy