Implemented rename_columns() #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
+ Coverage 96.52% 96.54% +0.01%
==========================================
Files 14 14
Lines 1238 1243 +5
==========================================
+ Hits 1195 1200 +5
Misses 43 43
Continue to review full report at Codecov.
|
cosmicBboy
reviewed
Jun 17, 2020
pandera/schemas.py
Outdated
|
|
||
| # We iterate over the existing columns dict and replace those keys | ||
| # that exist in the rename_dict | ||
| new_schema = deepcopy(self) |
There was a problem hiding this comment.
can reference copy.deepcopy here, since copy is already being imported
cosmicBboy
approved these changes
Jun 18, 2020
|
thanks for you contribution @baskervilski ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#201