-
-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renamed decorator as per issue #233 #235
Conversation
Thanks @Aditya1001001! I think you missed one on line 446 |
(FYI you can catch these kinds of things locally by running tests) |
@cosmicBboy I made the change and ran the decorator test script successfully. However, I did encounter a problem while simply running all tests:
Can you help with this? It will make testing my future PRs easier. |
interesting. are you running A full system report (OS, python version, etc) would be useful too |
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
=======================================
Coverage 96.33% 96.33%
=======================================
Files 15 15
Lines 1284 1284
=======================================
Hits 1237 1237
Misses 47 47
Continue to review full report at Codecov.
|
@cosmicBboy Yes I did run the tests from the root of the reop both times, it gave the aforementioned error while running all tests and worked when I just ran "pytest tests/test_decorators.py". OS is Windows 10 Pro, and I'm using Python 3.7.4 in a conda environment. |
The error you're seeing is because somehow the Can you do |
I tried to run it outside of my conda environment and that worked, why would that be? And how can I deal with that issue? |
did it work in the |
Yes, I meant the system python env, it did not work in the |
@Aditya1001001 would you mind creating a new issue for this? I'm unable to reproduce the failing test that you're seeing, and the Windows CI tests are passing, so I'm not sure what's going on. This PR looks good tho, I'll merge this in and discuss this on the new issue. |
Also, thanks for the PR, and congrats on your first contribution to pandera! 🚀 |
-[x] Rename
set_check_statistics
toregister_check_statistics
as per #233