Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename set_check_statistics to register_check_statistics #233

Closed
cosmicBboy opened this issue Jun 25, 2020 · 4 comments
Closed

rename set_check_statistics to register_check_statistics #233

cosmicBboy opened this issue Jun 25, 2020 · 4 comments
Assignees
@Aditya1001001
Labels
good first issue Good for newcomers

Comments

@cosmicBboy
Copy link
Collaborator

makes more sense to name the decorator this way.
@cosmicBboy cosmicBboy added the good first issue Good for newcomers label Jun 25, 2020
@Aditya1001001
Copy link
Contributor

I want to work on this issue, can you assign it to me?

@cosmicBboy
Copy link
Collaborator Author

Just assigned this to you @Aditya1001001 , let me know if you have any more questions!

Aditya1001001 added a commit to Aditya1001001/pandera that referenced this issue Jun 26, 2020
@Aditya1001001
renamed decorator as per issue unionai-oss#233
9a08e92
@Aditya1001001 Aditya1001001 mentioned this issue Jun 26, 2020
Merged
@Aditya1001001
Copy link
Contributor

@cosmicBboy I have made a draft pull request #235, can you go through it and check if it meets the requirements?

cosmicBboy pushed a commit that referenced this issue Jun 26, 2020
@Aditya1001001
renamed decorator as per issue #233 (#235)
8efc536 
* renamed decorator as per issue #233

* changed decorator name at line 446
@Aditya1001001 Aditya1001001 mentioned this issue Jun 27, 2020
Closed
@cosmicBboy
Copy link
Collaborator Author

fixed by #235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aditya1001001 Aditya1001001

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cosmicBboy @Aditya1001001