Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add from records to panderas dataframe #850 #859

Merged

Conversation

borissmidt
Copy link
Contributor

@borissmidt borissmidt commented May 16, 2022

#850 adding a from_records method which validates the dataframe.

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #859 (ff7b755) into dev (49b5fcf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #859   +/-   ##
=======================================
  Coverage   97.40%   97.41%           
=======================================
  Files          43       43           
  Lines        4163     4171    +8     
=======================================
+ Hits         4055     4063    +8     
  Misses        108      108           
Impacted Files Coverage Δ
pandera/typing/pandas.py 94.93% <100.00%> (+0.49%) ⬆️
pandera/typing/config.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cosmicBboy
Copy link
Collaborator

amazing @borissmidt ! thanks for the contribution 🙏

A few things to get this PR to through the finish line:

  1. fix the CI test errors (looks like a linting issue, also you should rebase onto the dev branch to fix unit test errors)
  2. add a unit test in tests/core to make sure that methods works as intended

@cosmicBboy cosmicBboy changed the base branch from master to dev August 8, 2022 01:23
@cosmicBboy cosmicBboy force-pushed the add-from_records-to-panderas-dataframe branch from 2045e34 to efdf152 Compare August 8, 2022 01:29
@cosmicBboy cosmicBboy merged commit 56265ff into unionai-oss:dev Aug 9, 2022
cosmicBboy added a commit that referenced this pull request Aug 10, 2022
* Add a from record that checks the schema for a pandas dataframe

* Add a from record that checks the schema for a pandas dataframe

* handle nox session.install issue

* fix lint

* fix noxfile issue

* remove unneeded types

* update type annotation

Co-authored-by: cosmicBboy <niels.bantilan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants