make df strategy less complex #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #988 A change in #658 introduced a step to handle str/object dtypes due to issues handling np.str_. Will need to look into whether that's still necessary in another PR, but this one compresses a bunch of `strategy.map` calls to a single one. This addresses an issue where the strategy would be way too long for schemas with many str/object columns. Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
|
Awesome. I tried this on my machine and was able to generate an example in ~3s. 👍🙏 |
Codecov ReportBase: 96.70% // Head: 96.70% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #989 +/- ##
=======================================
Coverage 96.70% 96.70%
=======================================
Files 42 42
Lines 4221 4224 +3
=======================================
+ Hits 4082 4085 +3
Misses 139 139
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #988
A change in #658 introduced a step to handle str/object dtypes due to issues handling np.str_. Will need to look into whether that's still necessary in another PR, but this one compresses a bunch of
strategy.mapcalls to a single one.This addresses an issue where the strategy would be way too long for schemas with many str/object columns.
Signed-off-by: Niels Bantilan niels.bantilan@gmail.com