[proposal] Add generic string parameter to types #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add FromS<T> and IntoS<T> traits. This traits is same as core traits From<T> and Into<T>. It needs due to compiler constraints which is not allow add generic implementations for core traits. - Add generic string parameter to the following types: - Patch<'a> -> Patch<S> - File<'a> -> File<S> - Hunk<'a> -> Hunk<S> - Line<'a> -> Line<S> This make it possible to do that types self owned when needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add generic string parameter to the following types:
Patch<'a>->Patch<S>File<'a>->File<S>Hunk<'a>->Hunk<S>Line<'a>->Line<S>This make it possible to do that types self owned when needed.
Add
FromS<T>andIntoS<T>traits. This traits is same as core traitsFrom<T>andInto<T>. It needs due to compiler constraints which is not allow add generic implementations for core traits.Have any ideas how to avoid adding
FromS/IntoS?