Result.Ok() and Maybe.Some() promote instead of transform #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Promise.resolve is like a cast: it promotes regular values to resolved promises, or uses the promise passed to it. Results' API for Result.Ok() and Maybe.Some() should match this. The current behaviour is based off of a mis-reading of Promise.resolve. These tests should validate the desired behaviour.
Passes all tests
Maybe.Some() and Result.Ok() now promote, so just use those. Also, .andThen() promotes, so let that happen automatically in `.all`s.
uniphil
added a commit
that referenced
this pull request
Oct 27, 2015
Result.Ok() and Maybe.Some() promote instead of transform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those functions return their argument if the argument is already an
ErrorOk, orNoneorSome, respectively.This brings the API closer to
Promise, specificallyPromise.resolve().