Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC][UN-8870] Create new tooltip and gender selector for checkout flow #113

Merged

Conversation

niceoutput
Copy link
Contributor

screenshot 2017-04-17 18 24 56

screenshot 2017-04-17 18 25 04

screenshot 2017-04-17 18 25 38

Copy link
Contributor

@mmelo mmelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update bower.json to: 2.3.0

height: 48px;
border: 2px solid color('borders','primary');
border-radius: 4px;
@include flex();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move mixin to top of other selectors (see line 19 of this same file)


& > div {
width: 50%;
background-color: color('background','primary');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

primary not needed

position: relative;

&:not(:first-child) {
border-left: 2px solid color('borders','primary');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

primary not needed

@mixin multi-selector() {
width: 100%;
height: 48px;
border: 2px solid color('borders','primary');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

primary not needed

Copy link
Contributor

@asantos00 asantos00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

@mmelo mmelo merged commit 0f3e5a2 into master Apr 18, 2017
@mmelo mmelo deleted the UN-8870-create-tooltip-and-gender-selector-checkout-flow branch April 18, 2017 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants