🔨 change signatures #44
Conversation
README.md
Outdated
| import factory from 'trampss-redux-factory' | ||
| export default factory(/* middlewares */)('id')('api')('todos') | ||
| import { map } from 'trampss-redux-factory' | ||
| export default map({ key: 'id', path: 'api', name: 'todos' }) | ||
| ``` | ||
| That's it, you exported a reducer function you can register thanks to combinerReducer in Redux. |
There was a problem hiding this comment.
"That's it, you just have to export the reducer function and you can register it through combinerReducer in Redux"
There was a problem hiding this comment.
What about That's it, you just exported the reducer function and now you can register it through combinerReducer in Redux. ?
The reducer function is already exported (this is the code above the sentence)
|
|
||
| export default factory({ type: 'uniq', /* other options */ }) | ||
| ``` | ||
|
|
||
| ### state |
There was a problem hiding this comment.
space more after initialized: true,
|
|
||
| // params checkers | ||
| const isMiddleware = params => params.engine || params.pre || params.post | ||
| const isOptions = params => (!!params.name) || (typeof params === 'string') |
There was a problem hiding this comment.
no pb on lint ? !!params.name
There was a problem hiding this comment.
why ? !! is about converting a truthy value to true
| } | ||
|
|
||
| export const uniq = factory({ type: 'uniq' }) |
There was a problem hiding this comment.
uniq is not connoted with the function uniq of lodash :/
uniq => single ?
map => multi ?
i think, the name of funciton dont match with the features.
There was a problem hiding this comment.
I agree and I would prefer an issue to argue about it
There was a problem hiding this comment.
uniq => simple ?
map => complex ?
@bpetetot An idea ? :)
#35
README : https://github.com/Trampss/trampss-redux-factory/blob/signature/README.md
TYPES : https://github.com/Trampss/trampss-redux-factory/blob/signature/TYPES.md