Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change type names (uniq/map) #45

Closed
fabienjuif opened this issue Jul 17, 2017 · 4 comments
Closed

change type names (uniq/map) #45

fabienjuif opened this issue Jul 17, 2017 · 4 comments
Assignees
@fabienjuif
Labels
to ship in 3.0.0

Comments

@fabienjuif
Copy link
Member

#44
@fabienjuif fabienjuif mentioned this issue Jul 17, 2017
Merged
@fabienjuif
Copy link
Member Author

Proposition from coworkers :

  • keyValue
  • simpleObject

@bpetetot
Copy link
Collaborator

I would have named them :

  • array (for map)
  • object (for uniq)

@fabienjuif
Copy link
Member Author

  • I don't like array because this is not an array (this is a map, with an array) => Maybe we'll add a simple array reducer sometimes
  • I like object but I'm afraid of possibles bugs with Object it could generates for beginers

@fabienjuif fabienjuif mentioned this issue Jul 18, 2017
Merged
@fabienjuif fabienjuif self-assigned this Jul 18, 2017
@fabienjuif
Copy link
Member Author

Names are :

  • keyValue
  • simpleObject

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabienjuif fabienjuif

Labels
to ship in 3.0.0
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bpetetot @fabienjuif