This repository has been archived by the owner on Jul 19, 2022. It is now read-only.
Add DownloadModal with click to copy #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new download button that appear under a namespace perspective. Clicking this button will launch a modal that has a "click to copy" functionality. * Copy on click is built with a WebComponent (`CopyOnClick.js`) rendered from Elm via a new `CopyField` module, which includes a new clipboard `Icon`. * The perspective in the sidebar is now rendered via `Sidebar.header` and `Sidebar.headerItem` to include proper padding and a bottom divider.
hojberg
force-pushed
the
download-modal-2
branch
from
39ba3c0
to
2524205
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add a new download button that appear under a namespace perspective.
Clicking this button will launch a modal that has a "click to copy"
functionality.
Superseedes: #205
Closes: #145
Implementation notes
CopyOnClick.js) renderedfrom Elm via a new
CopyFieldmodule, which includes a new clipboardIcon.Sidebar.headerand
Sidebar.headerItemto include proper padding and a bottom divider.Loose ends
The main downside with downloading libraries via Share is that the user has to download the entirety of Share (61mb at the time of this PR) to use a single library, which certainly is not ideal.