This repository has been archived by the owner on Jul 19, 2022. It is now read-only.
Move modals out of UnisonShare.App #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor modals out of UnisonShare.App into UnisonShare.AppModal. This leaves UnisonLocal alone, though that could also benefit from a similar refactor. Also change the webpack config and npm start scripts to allow for starting the UnisonLocal and UnisonShare apps separately.
hojberg
force-pushed
the
share-appModal
branch
from
8a6bc60
to
22866ce
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Refactor modals out of UnisonShare.App into UnisonShare.AppModal.
This leaves UnisonLocal alone, though that could also benefit from a
similar refactor.
Also change the webpack config and npm start scripts to allow for
starting the UnisonLocal and UnisonShare apps separately."
Notes
This is part of an effort of stripping out elements of UnisonShare.App in preparation for a new front page for Share.