This repository has been archived by the owner on Jul 19, 2022. It is now read-only.
Add keyboard support to catalog search #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hojberg
commented
Jan 11, 2022
| { operatingSystem = operatingSystemFromString flags.operatingSystem | ||
| , basePath = flags.basePath | ||
| , apiBasePath = ApiBasePath flags.apiBasePath | ||
| , appContext = AppContext.fromString flags.appContext | ||
| , navKey = navKey |
There was a problem hiding this comment.
Moved the navKey out of the App model and into Env so that we can navigate from any page.
When searching through the catalog support keyboard navigation with up and down arrows as well as selection with enter and indexed selection with ; followed by an index number. This mirrors the functionality of the Finder.
hojberg
force-pushed
the
catalog-search-keyboard
branch
from
8d8fe28
to
755c41c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The user should be able to select search results by using the keyboard.
Solution
When searching through the catalog support keyboard navigation with up
and down arrows as well as selection with enter and indexed selection
with ; followed by an index number. This mirrors the functionality of
the Finder.