Some ability checking adjustments #3149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed an erroneous case when equating two sets of abilities. Normally
we try to unify pieces of them with pieces of the opposite side to
render them equal. However, in certain cases where that wasn't
possible, we would just not do anything, and also not fail. This code
tries some additional unification cases, and properly throws an error
if nothing will work.
- This caused some knock-on problems with certain test examples. For
instance, if you annotate a handler as `Request {...} r -> ...`, then
variables made up in the function body will fail to unify with the
rigidly defined row. So ability checking for cases has been modified
to avoid making up superfluous variables.
pchiusano
approved these changes
Jun 24, 2022
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an erroneous case when equating two sets of abilities. Normally we try to unify pieces of them with pieces of the opposite side to render them equal. However, in certain cases where that wasn't possible, we would just not do anything, and also not fail. This code tries some additional unification cases, and properly throws an error if nothing will work.
This caused some knock-on problems with certain test examples. For instance, if you annotate a handler as
Request {...} r -> ..., then variables made up in the function body will fail to unify with the rigidly defined row. So ability checking for cases has been modified to avoid making up superfluous variables.Fixes #3037 and #2848