Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some ability checking adjustments #3149

Merged
merged 2 commits into from Jun 24, 2022
Merged

Some ability checking adjustments #3149

merged 2 commits into from Jun 24, 2022

Commits on Jun 23, 2022

  1. Some adjustments to ability checking 

    - Fixed an erroneous case when equating two sets of abilities. Normally
  we try to unify pieces of them with pieces of the opposite side to
  render them equal. However, in certain cases where that wasn't
  possible, we would just not do anything, and also not fail. This code
  tries some additional unification cases, and properly throws an error
  if nothing will work.
- This caused some knock-on problems with certain test examples. For
  instance, if you annotate a handler as `Request {...} r -> ...`, then
  variables made up in the function body will fail to unify with the
  rigidly defined row. So ability checking for cases has been modified
  to avoid making up superfluous variables.
    @dolio
    dolio committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    3b16d19 View commit details
    Browse the repository at this point in the history

  2. Add test transcript

    @dolio
    dolio committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    d85e17e View commit details
    Browse the repository at this point in the history