#3137 - Added exit flag on launch #3158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisPenner
approved these changes
Jun 29, 2022
There was a problem hiding this comment.
Looks good, thanks for taking this one 👍🏼
-
Please also add yourself to the contributors file: https://github.com/unisonweb/unison/blob/trunk/CONTRIBUTORS.markdown
-
Please include a short description in the PR description so we have a record of what this does
Then and I can merge this 😄
|
Done |
ChrisPenner
added
the
ready-to-merge
mergify
bot
removed
the
ready-to-merge
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We want to have an option, by adding a new flag
--exit, to close REPL when runningucm --codebasecreate pathcommand.#3137
Implementation notes
I added a global flag so we can later use it in potentially another commands.