feat: add lib.install command
#4953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryairani
reviewed
May 16, 2024
| import Unison.Codebase.Editor.Git (withStatus) | ||
| import Unison.Codebase.Editor.Git qualified as Git | ||
| import Unison.Codebase.Editor.RemoteRepo (ReadGitRemoteNamespace) | ||
| import Unison.Codebase.GitError qualified as GitError | ||
| import Unison.Codebase.Path | ||
| import Unison.Codebase.Path qualified as Path | ||
| import Unison.Codebase.SqliteCodebase.Conversions qualified as Cv | ||
| import Unison.Codebase.SqliteCodebase.Operations qualified as SqliteCodebase.Operations | ||
| import Unison.Codebase.SyncMode (SyncMode) | ||
| import Unison.Codebase.Type | ||
| ( Codebase (..), | ||
| GitError (GitCodebaseError), | ||
| PushGitBranchOpts (..), | ||
| SyncToDir, | ||
| ) | ||
| import Unison.Codebase.Type (Codebase (..), GitError) |
There was a problem hiding this comment.
Could you add a high level description to the PR about what is happening with these
There was a problem hiding this comment.
Ok I guess I found it in the commit message, or is there more to it?
There was a problem hiding this comment.
The SyncMode argument was totally ignored, so debug.pull-exhaustive didn't do anything special.
aryairani
approved these changes
May 16, 2024
|
I'm getting a PR going for share to update the install modals to this new command 🎉. |
Thank you! |
|
Here's the PR: unisoncomputing/share-ui#6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Edit: the help now looks like this
This PR adds a
lib.install(alias:install.lib) command to replacepullfor installing a dependency intolib.It's different than
pullin a couple ways:pull @unison/base/releases/4.0.0 lib.base_4_0_0just becomeslib.install @unison/base/releases/4.0.0, and the name is picked automatically (see screenshot).Test coverage
I tested this manually