Unison local Definition Diffs API #4964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisPenner
commented
May 17, 2024
There was a problem hiding this comment.
I know this output is really hard to read, but it will at least serve as a regression test to ensure the diffs don't break unexpectedly.
aryairani
approved these changes
May 17, 2024
|
@ChrisPenner go ahead and merge these once the tests are passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds definition diff API to Unison Local.
Implementation notes
Adds
/api/projects/<slug>/diff/termsand/api/projects/<slug>/diff/typeswhich return the same format as ShareTest coverage
Added a simple transcript test
Loose ends
Not sure when we'll have time to add this to the UI, but at the very least it serves as a mechanism to add some testing for the feature in
unisonrather than just inshare-apicc @hojberg