Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Covariates after from fill_missing_values #1075

Closed
nydaniel opened this issue Jul 14, 2022 · 3 comments
Closed

Static Covariates after from fill_missing_values #1075

nydaniel opened this issue Jul 14, 2022 · 3 comments
Assignees
Labels
bug Something isn't working
Projects

Comments

@nydaniel
Copy link

nydaniel commented Jul 14, 2022

When using the function fill_missing_values the returned TimeSeries does not have the static covariates of the original TimeSeries

values = np.array([0, 1, 2, np.nan])
static_series = pd.Series([10, 20, 30], index=['a', 'b', 'c'])
ts = darts.TimeSeries.from_values(values, static_covariates=static_series)
print(ts.has_static_covariates)
new_ts = fill_missing_values(ts, fill=0.0)
print(new_ts.has_static_covariates)

This code outputs True for the first print statement and False for the second print statement.

@nydaniel nydaniel added the triage Issue waiting for triaging label Jul 14, 2022
@hrzn
Copy link
Contributor

hrzn commented Jul 14, 2022

Good catch, that's a bug, will fix, thanks!

@hrzn hrzn added bug Something isn't working and removed triage Issue waiting for triaging labels Jul 14, 2022
@hrzn hrzn self-assigned this Jul 14, 2022
@hrzn hrzn added this to To do in darts via automation Jul 14, 2022
@hrzn hrzn moved this from To do to In progress in darts Jul 14, 2022
@nydaniel
Copy link
Author

Happy to help and thanks a lot for the development effort

@hrzn hrzn moved this from In progress to To do in darts Aug 9, 2022
@hrzn
Copy link
Contributor

hrzn commented Aug 22, 2022

This one was fixed in #1076 and released.

@hrzn hrzn closed this as completed Aug 22, 2022
darts automation moved this from To do to Done Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
darts
Done
Development

No branches or pull requests

2 participants