Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate static covs and hierarchy in missing value filler #1076

Merged
merged 4 commits into from Jul 18, 2022

Conversation

hrzn
Copy link
Contributor

@hrzn hrzn commented Jul 14, 2022

Solves #1075

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2022

Codecov Report

Merging #1076 (ce351f6) into master (8b6d1ab) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1076      +/-   ##
==========================================
- Coverage   93.16%   93.15%   -0.02%     
==========================================
  Files          78       78              
  Lines        7948     7935      -13     
==========================================
- Hits         7405     7392      -13     
  Misses        543      543              
Impacted Files Coverage Δ
darts/utils/missing_values.py 96.96% <100.00%> (ø)
darts/timeseries.py 92.14% <0.00%> (-0.07%) ⬇️
...arts/models/forecasting/torch_forecasting_model.py 89.51% <0.00%> (-0.05%) ⬇️
darts/models/forecasting/block_rnn_model.py 98.14% <0.00%> (-0.04%) ⬇️
darts/models/forecasting/nhits.py 99.25% <0.00%> (-0.01%) ⬇️
darts/datasets/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b6d1ab...ce351f6. Read the comment docs.

Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for quickly fixing these issues with static covs :)

@hrzn hrzn merged commit 7f32ef6 into master Jul 18, 2022
@madtoinou madtoinou deleted the feat/propagate-attrs-in-fillers branch July 5, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants