Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small issues with N-BEATS / NHiTS #1103

Closed
hrzn opened this issue Jul 29, 2022 · 0 comments · Fixed by #1130
Closed

Fix small issues with N-BEATS / NHiTS #1103

hrzn opened this issue Jul 29, 2022 · 0 comments · Fixed by #1130
Labels
bug Something isn't working
Projects

Comments

@hrzn
Copy link
Contributor

hrzn commented Jul 29, 2022

See: https://gitter.im/u8darts/darts?at=62e22c6a76cd751a2f97b480

@hrzn hrzn created this issue from a note in darts (To do) Jul 29, 2022
@hrzn hrzn added the bug Something isn't working label Jul 29, 2022
rijkvandermeulen pushed a commit to rijkvandermeulen/darts that referenced this issue Aug 7, 2022
…iso self.num_stacks. Also adjusted the API reference docs
hrzn added a commit to rijkvandermeulen/darts that referenced this issue Aug 7, 2022
hrzn added a commit to rijkvandermeulen/darts that referenced this issue Aug 8, 2022
@hrzn hrzn moved this from To do to In progress in darts Aug 8, 2022
@hrzn hrzn linked a pull request Aug 8, 2022 that will close this issue
@hrzn hrzn moved this from In progress to In review in darts Aug 8, 2022
rijkvandermeulen pushed a commit to rijkvandermeulen/darts that referenced this issue Aug 8, 2022
rijkvandermeulen pushed a commit to rijkvandermeulen/darts that referenced this issue Aug 8, 2022
hrzn added a commit to rijkvandermeulen/darts that referenced this issue Aug 9, 2022
hrzn added a commit that referenced this issue Aug 9, 2022
)

* #1101 Implemented min_train_series_length for Theta and FourTheta

* #1103 Placed changelog entry under the Unreleased section

Co-authored-by: Rijk van der Meulen <rijk.vandermeulen@eyeon.nl>
Co-authored-by: Julien Herzen <julien@unit8.co>
hrzn added a commit to rijkvandermeulen/darts that referenced this issue Aug 9, 2022
@hrzn hrzn closed this as completed in #1130 Aug 9, 2022
hrzn added a commit that referenced this issue Aug 9, 2022
* #1103 Fixed mistake in NBEATS model where num_stacks was used iso self.num_stacks. Also adjusted the API reference docs

* #1103 Small fixes

Co-authored-by: Rijk van der Meulen <rijk.vandermeulen@eyeon.nl>
Co-authored-by: Julien Herzen <julien@unit8.co>
darts automation moved this from In review to Done Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
darts
Done
Development

Successfully merging a pull request may close this issue.

1 participant