Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Inconsistent default parameters between backtest and gridsearch #2236

Closed
thomktz opened this issue Feb 20, 2024 · 0 comments · Fixed by #2243
Closed

[BUG] - Inconsistent default parameters between backtest and gridsearch #2236

thomktz opened this issue Feb 20, 2024 · 0 comments · Fixed by #2243
Labels
bug Something isn't working

Comments

@thomktz
Copy link
Contributor

thomktz commented Feb 20, 2024

Describe the bug
The backtest and gridsearch methods of forecasting models have inconsistent default values to their start (None v.s. 0.5) keyword argument. This makes the scores returned by gridsearch inconsistent with the scores manually computed through backtest with the same model parameters

Expected behavior
Set both to None or both to 0.5

**System

  • darts version: 0.27.0

I can make this PR

@thomktz thomktz added bug Something isn't working triage Issue waiting for triaging labels Feb 20, 2024
@madtoinou madtoinou removed the triage Issue waiting for triaging label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants