Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default gridsearch kwarg value #2243

Merged
merged 3 commits into from Feb 26, 2024

Conversation

thomktz
Copy link
Contributor

@thomktz thomktz commented Feb 21, 2024

Fixes #2236

Summary

Parameter default value change in gridsearch. I picked None as the default value since it seems to be the newer feature.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4600453) 93.88% compared to head (7b00602) 93.87%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2243      +/-   ##
==========================================
- Coverage   93.88%   93.87%   -0.02%     
==========================================
  Files         135      135              
  Lines       13434    13420      -14     
==========================================
- Hits        12613    12598      -15     
- Misses        821      822       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for this contribution @thomktz 🚀

@dennisbader dennisbader merged commit b9e6d8b into unit8co:master Feb 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Inconsistent default parameters between backtest and gridsearch
3 participants