Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove logger.setLevel() #1034

Merged
merged 1 commit into from
Jun 23, 2022
Merged

remove logger.setLevel() #1034

merged 1 commit into from
Jun 23, 2022

Conversation

brunnedu
Copy link
Contributor

Summary

  • no usage of logger.setLevel in darts.logging.get_logger anymore
  • users can use logging.basicConfig() before importing darts models to decide whether they want the model warning logs

@codecov-commenter
Copy link

Codecov Report

Merging #1034 (c31fc26) into master (321fade) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1034      +/-   ##
==========================================
- Coverage   91.32%   91.30%   -0.02%     
==========================================
  Files          77       77              
  Lines        7871     7856      -15     
==========================================
- Hits         7188     7173      -15     
  Misses        683      683              
Impacted Files Coverage Δ
darts/logging.py 75.92% <ø> (-0.44%) ⬇️
darts/models/__init__.py 86.04% <0.00%> (-0.32%) ⬇️
darts/timeseries.py 91.99% <0.00%> (-0.07%) ⬇️
...arts/models/forecasting/torch_forecasting_model.py 89.51% <0.00%> (-0.05%) ⬇️
darts/models/forecasting/block_rnn_model.py 98.14% <0.00%> (-0.04%) ⬇️
darts/models/forecasting/nhits.py 99.25% <0.00%> (-0.01%) ⬇️
darts/datasets/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 321fade...c31fc26. Read the comment docs.

@brunnedu brunnedu merged commit 945ded5 into master Jun 23, 2022
@madtoinou madtoinou deleted the fix/logging branch July 5, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants