Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speedup static covariates when no casting is needed #1053

Merged
merged 3 commits into from
Jul 18, 2022

Conversation

hrzn
Copy link
Contributor

@hrzn hrzn commented Jul 1, 2022

Static covariates of very high dimensionality can cause performance issues due to casting
This PR avoids the casting where/when possible.

@hrzn hrzn added this to In review in darts via automation Jul 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2022

Codecov Report

Merging #1053 (835887c) into master (8b6d1ab) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1053      +/-   ##
==========================================
- Coverage   93.16%   93.15%   -0.01%     
==========================================
  Files          78       78              
  Lines        7948     7937      -11     
==========================================
- Hits         7405     7394      -11     
  Misses        543      543              
Impacted Files Coverage Δ
darts/timeseries.py 92.15% <100.00%> (-0.05%) ⬇️
...arts/models/forecasting/torch_forecasting_model.py 89.51% <0.00%> (-0.05%) ⬇️
darts/models/forecasting/block_rnn_model.py 98.14% <0.00%> (-0.04%) ⬇️
darts/models/forecasting/nhits.py 99.25% <0.00%> (-0.01%) ⬇️
darts/datasets/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b6d1ab...835887c. Read the comment docs.

Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 👍

@hrzn hrzn merged commit ad986f1 into master Jul 18, 2022
darts automation moved this from In review to Done Jul 18, 2022
@madtoinou madtoinou deleted the feat/speedup-static-cov branch July 5, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
darts
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants