Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coloring for graphs #1056

Merged
merged 7 commits into from Jul 18, 2022
Merged

Update coloring for graphs #1056

merged 7 commits into from Jul 18, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Jul 4, 2022

Summary

Currently the charting in Darts messes up if you are using custom settings in matplotlib. I am creating a default colors argument so that users can choose whether they want Dart's default colors. If this is a desired feature I can add it to the rest of the charting functions in this file, and any other files you point out.

Copy link
Contributor

@hrzn hrzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this one. I think we could add it. Could you also maybe do the same for the plot() function in TimeSeries ? Also we could maybe think of it as "default formatting" instead of limiting it to colors only, WDYT?

The tests are failing because of black - could you apply black and update?

@colin99d
Copy link
Contributor Author

colin99d commented Jul 9, 2022

Thanks for the feedback. All requested changes have been implemented.

Copy link
Contributor

@hrzn hrzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #1056 (87d15eb) into master (8b6d1ab) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1056      +/-   ##
==========================================
- Coverage   93.16%   93.16%   -0.01%     
==========================================
  Files          78       78              
  Lines        7948     7941       -7     
==========================================
- Hits         7405     7398       -7     
  Misses        543      543              
Impacted Files Coverage Δ
darts/timeseries.py 92.14% <100.00%> (-0.07%) ⬇️
darts/utils/statistics.py 88.65% <100.00%> (+0.36%) ⬆️
...arts/models/forecasting/torch_forecasting_model.py 89.51% <0.00%> (-0.05%) ⬇️
darts/models/forecasting/block_rnn_model.py 98.14% <0.00%> (-0.04%) ⬇️
darts/models/forecasting/nhits.py 99.25% <0.00%> (-0.01%) ⬇️
darts/datasets/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b6d1ab...87d15eb. Read the comment docs.

@hrzn hrzn added this to In review in darts via automation Jul 12, 2022
@hrzn hrzn merged commit 1fadc58 into unit8co:master Jul 18, 2022
darts automation moved this from In review to Done Jul 18, 2022
@colin99d colin99d deleted the patch-1 branch August 10, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
darts
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants