Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/improve zero length datasets #1066

Merged
merged 8 commits into from
Aug 9, 2022
Merged

Conversation

hrzn
Copy link
Contributor

@hrzn hrzn commented Jul 12, 2022

  • Solves RNN Residuals #1062 (bug in min_train_length for RNNModel)
  • Improves error messages.
  • Introduces retrain option in residuals() method

@hrzn hrzn linked an issue Jul 12, 2022 that may be closed by this pull request
@hrzn hrzn mentioned this pull request Jul 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #1066 (6f89562) into master (5ceac68) will decrease coverage by 0.06%.
The diff coverage is 68.42%.

@@            Coverage Diff             @@
##           master    #1066      +/-   ##
==========================================
- Coverage   93.76%   93.69%   -0.07%     
==========================================
  Files          80       80              
  Lines        8207     8213       +6     
==========================================
  Hits         7695     7695              
- Misses        512      518       +6     
Impacted Files Coverage Δ
darts/models/forecasting/forecasting_model.py 96.36% <ø> (ø)
...arts/models/forecasting/torch_forecasting_model.py 88.69% <62.50%> (-0.91%) ⬇️
darts/models/forecasting/rnn_model.py 97.64% <100.00%> (+0.08%) ⬆️
darts/timeseries.py 92.23% <0.00%> (-0.07%) ⬇️
darts/models/forecasting/block_rnn_model.py 98.24% <0.00%> (-0.04%) ⬇️
darts/models/forecasting/nhits.py 98.55% <0.00%> (-0.02%) ⬇️
darts/datasets/__init__.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hrzn hrzn merged commit e9f2128 into master Aug 9, 2022
@madtoinou madtoinou deleted the feat/improve-zero-length-datasets branch July 5, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RNN Residuals
2 participants