Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/predict single value #108

Merged
merged 3 commits into from Jun 22, 2020
Merged

Fix/predict single value #108

merged 3 commits into from Jun 22, 2020

Conversation

pennfranc
Copy link
Contributor

Summary

  • Solved issue of TorchForecastingModel.predict(n) throwing an error at n=1.
  • Added tests for both RNN and TCN that make sure a single value can be predicted.
  • Manually set torch random seed in TCN test case to make sure it does not randomly fail (I believe it was possible with a very small probability, not anymore though).

@pennfranc pennfranc merged commit 172f3ed into develop Jun 22, 2020
@pennfranc pennfranc deleted the fix/predict-single-value branch June 22, 2020 14:30
hrzn pushed a commit that referenced this pull request Jun 25, 2020
@pennfranc @TheMP @hrzn
Fix/predict single value (#108)
e414c73 
* fix(TorchForecastingModel): solved bug at TorchForecastingModel.predict(n) with n = 1

* feature(testing): added tests for length 1 predictions for RNN and TCN, set torch random seed for TCN test

Co-authored-by: pennfranc <flaessig@student.ethz.ch>
Co-authored-by: TheMP <marek.pasieka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheMP TheMP TheMP approved these changes

@hrzn hrzn Awaiting requested review from hrzn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pennfranc @TheMP