Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/fix various issues #1106

Merged
merged 4 commits into from Aug 5, 2022
Merged

Fix/fix various issues #1106

merged 4 commits into from Aug 5, 2022

Conversation

hrzn
Copy link
Contributor

@hrzn hrzn commented Jul 31, 2022

  • Fixes a recent issue with xarray 2022-06, which changed reset_index() behaviour (see Coordinate promotion workaround broken pydata/xarray#6607). We now re-build the DataArrays from scratch with proper coordinates instead of relying on reset_index().

  • Fixes an issue due to the latest release of StatsForecast, which contained a breaking change, by fixing the version number.

  • Small improvements to TimeSeries user guide.

@hrzn hrzn added this to In review in darts via automation Jul 31, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2022

Codecov Report

Merging #1106 (a695909) into master (caccce1) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1106      +/-   ##
==========================================
- Coverage   93.65%   93.64%   -0.02%     
==========================================
  Files          79       79              
  Lines        8137     8121      -16     
==========================================
- Hits         7621     7605      -16     
  Misses        516      516              
Impacted Files Coverage Δ
darts/dataprocessing/dtw/dtw.py 94.20% <100.00%> (-0.13%) ⬇️
darts/timeseries.py 92.15% <0.00%> (-0.07%) ⬇️
...arts/models/forecasting/torch_forecasting_model.py 89.54% <0.00%> (-0.05%) ⬇️
darts/models/forecasting/block_rnn_model.py 98.24% <0.00%> (-0.04%) ⬇️
darts/models/forecasting/nhits.py 98.55% <0.00%> (-0.02%) ⬇️
darts/datasets/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caccce1...a695909. Read the comment docs.

Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing these issues! Looks good 👍

@hrzn hrzn merged commit 6ec5e72 into master Aug 5, 2022
darts automation moved this from In review to Done Aug 5, 2022
@hrzn hrzn deleted the fix/fix-various-issues branch August 5, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
darts
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants