Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when using latest version of Prophet #1208

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Conversation

hrzn
Copy link
Contributor

@hrzn hrzn commented Sep 12, 2022

Solves a bug with a breaking change in latest version of Prophet 1.1.1

@codecov-commenter
Copy link

Codecov Report

Base: 93.74% // Head: 93.73% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (3e7a049) compared to base (e617fdc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1208      +/-   ##
==========================================
- Coverage   93.74%   93.73%   -0.01%     
==========================================
  Files          83       83              
  Lines        8407     8394      -13     
==========================================
- Hits         7881     7868      -13     
  Misses        526      526              
Impacted Files Coverage Δ
darts/models/forecasting/exponential_smoothing.py 100.00% <ø> (ø)
darts/models/forecasting/prophet_model.py 94.24% <100.00%> (ø)
darts/timeseries.py 92.23% <0.00%> (-0.07%) ⬇️
...arts/models/forecasting/torch_forecasting_model.py 87.45% <0.00%> (-0.05%) ⬇️
darts/models/forecasting/block_rnn_model.py 98.24% <0.00%> (-0.04%) ⬇️
darts/models/forecasting/nhits.py 99.27% <0.00%> (-0.01%) ⬇️
darts/datasets/__init__.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hrzn hrzn merged commit 28ca88d into master Sep 12, 2022
@madtoinou madtoinou deleted the fix/issue-with-prophet branch July 5, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants