Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ensemble predict with series #1357

Merged
merged 3 commits into from Nov 13, 2022
Merged

Conversation

dennisbader
Copy link
Collaborator

Fixes #1340

Summary

  • fixes several issues in RegressionEnsembleModel, when using only a single target series at fitting time, and passing a new/multiple series to predict()
  • removes "static" ìs_single_seriesattribute from ensemble model, and instead recompute it whenever we get a newseries`.
  • removes some unnecessary test skips for old regression models torch dependency

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2022

Codecov Report

Base: 93.89% // Head: 93.88% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (d32e5d0) compared to base (a0ebdfd).
Patch coverage: 92.85% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1357      +/-   ##
==========================================
- Coverage   93.89%   93.88%   -0.02%     
==========================================
  Files          78       78              
  Lines        8522     8508      -14     
==========================================
- Hits         8002     7988      -14     
  Misses        520      520              
Impacted Files Coverage Δ
darts/models/forecasting/ensemble_model.py 91.66% <83.33%> (-0.65%) ⬇️
...ts/models/forecasting/regression_ensemble_model.py 100.00% <100.00%> (ø)
darts/timeseries.py 92.34% <0.00%> (-0.06%) ⬇️
...arts/models/forecasting/torch_forecasting_model.py 87.08% <0.00%> (-0.06%) ⬇️
darts/models/forecasting/block_rnn_model.py 98.24% <0.00%> (-0.04%) ⬇️
darts/models/forecasting/nhits.py 99.27% <0.00%> (-0.01%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@hrzn hrzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dennisbader dennisbader merged commit 2590a69 into master Nov 13, 2022
@dennisbader dennisbader deleted the fix/ensemble_predict_with_series branch November 13, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Error in running model.predict with RegressionEnsembleModel
3 participants