New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/bug in ensemble models to support underlying stochastic models #1423
Fix/bug in ensemble models to support underlying stochastic models #1423
Conversation
- added _is_probabilistic to ensemble classes
Codecov ReportBase: 93.67% // Head: 93.67% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1423 +/- ##
==========================================
- Coverage 93.67% 93.67% -0.01%
==========================================
Files 94 94
Lines 9398 9387 -11
==========================================
- Hits 8804 8793 -11
Misses 594 594
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @eliane-maalouf , looks good to me :)
Only added some minor suggestions.
…ensemblemodel-support-num_samples-largerthan1
thanks @dennisbader for your review. It should be ok now :) |
darts/models/forecasting/theta.py
Outdated
@@ -182,6 +182,9 @@ def min_train_series_length(self) -> int: | |||
else: | |||
return 3 | |||
|
|||
def _is_probabilistic(self) -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one can be removed as well :) after that all looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
;) missed this one, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Fixes #1390 .
Summary