Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/backtest multiple series #1517

Merged
merged 2 commits into from Jan 26, 2023
Merged

Fix/backtest multiple series #1517

merged 2 commits into from Jan 26, 2023

Conversation

hrzn
Copy link
Contributor

@hrzn hrzn commented Jan 26, 2023

Fixes #1516
Fix an issue with backtest() on multiple series.

@hrzn hrzn added this to In review in darts via automation Jan 26, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 94.08% // Head: 94.04% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (9a383f3) compared to base (7753a6b).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1517      +/-   ##
==========================================
- Coverage   94.08%   94.04%   -0.05%     
==========================================
  Files         122      122              
  Lines       10981    10967      -14     
==========================================
- Hits        10332    10314      -18     
- Misses        649      653       +4     
Impacted Files Coverage Δ
darts/models/forecasting/forecasting_model.py 97.06% <ø> (ø)
darts/utils/data/tabularization.py 99.27% <0.00%> (-0.73%) ⬇️
darts/timeseries.py 92.14% <0.00%> (-0.23%) ⬇️
darts/ad/anomaly_model/filtering_am.py 91.93% <0.00%> (-0.13%) ⬇️
...arts/models/forecasting/torch_forecasting_model.py 89.52% <0.00%> (-0.05%) ⬇️
darts/models/forecasting/block_rnn_model.py 98.24% <0.00%> (-0.04%) ⬇️
darts/models/forecasting/nhits.py 99.27% <0.00%> (-0.01%) ⬇️
darts/datasets/__init__.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hrzn hrzn merged commit 33d8a33 into master Jan 26, 2023
darts automation moved this from In review to Done Jan 26, 2023
@louisoutin
Copy link

Is it possible to have a new release including this change please? :)

@dennisbader dennisbader moved this from Done to Released in darts May 23, 2023
@madtoinou madtoinou deleted the fix/backtest-multiple-series branch July 5, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
darts
Released
Development

Successfully merging this pull request may close these issues.

[BUG] .backtest method is not working
5 participants