Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix quantile detector when low/high threshold are the same #1553

Merged
merged 10 commits into from
Feb 16, 2023
Merged

fix quantile detector when low/high threshold are the same #1553

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1fd44fc
fix quantile detector when low/high threshold are the same
julien12234 Feb 10, 2023
c38ac9d
add test
julien12234 Feb 10, 2023
198d9b3
Update darts/ad/detectors/threshold_detector.py
julien12234 Feb 10, 2023
05dbd06
change syntax
julien12234 Feb 10, 2023
f904835
pre commit
julien12234 Feb 10, 2023
02bc46a
pre commit
julien12234 Feb 10, 2023
e70e70e
Merge branch 'master' into fix/quantile_detector
madtoinou Feb 12, 2023
92e8567
Merge branch 'master' into fix/quantile_detector
hrzn Feb 16, 2023
d4dd59e
Merge branch 'master' into fix/quantile_detector
madtoinou Feb 16, 2023
57d8ab2
Merge branch 'master' into fix/quantile_detector
hrzn Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions darts/ad/detectors/threshold_detector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,12 @@ def _prep_thresholds(q):
raise_if_not(
all(
[
l < h
l <= h
for (l, h) in zip(self.low_threshold, self.high_threshold)
if ((l is not None) and (h is not None))
]
),
"all values in `low_threshold` must be lower than their corresponding value in `high_threshold`.",
"all values in `low_threshold` must be lower or equal than their corresponding value in `high_threshold`.",
julien12234 marked this conversation as resolved.
Show resolved Hide resolved
)

def _detect_core(self, series: TimeSeries) -> TimeSeries:
Expand Down