[Feature] Support a user defined function name in the window transformation output #1676
Conversation
|
@madtoinou FYI |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #1676 +/- ##
==========================================
- Coverage 94.14% 94.06% -0.08%
==========================================
Files 125 125
Lines 11389 11379 -10
==========================================
- Hits 10722 10704 -18
- Misses 667 675 +8
... and 9 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
I realize that I did not validate that the |
There was a problem hiding this comment.
Looking good to me 🚀
I would just leave the "sum" transform name in the test, "TotalOperation" is less understandable in my opinion and we need to cover the case where the function name is not provided and fn is not "apply".
It's probably not necessary to check that function_name is a string, the documentation is clear and I don't see which other type the users might be tempted to use...
darts/tests/dataprocessing/transformers/test_window_transformations.py
Outdated
Show resolved
Hide resolved
darts/tests/dataprocessing/transformers/test_window_transformations.py
Outdated
Show resolved
Hide resolved
JQGoh
force-pushed
the
feat/user-defined-fn-name-window-trans
branch
from
9993323
to
aada4ac
Compare
|
@dennisbader May I check that any chance that this PR could be in time as part of the new release (0.23.2)? Thanks |
There was a problem hiding this comment.
Looks good, thanks @JQGoh 🚀 And yes, this will be part of the 0.24.0 release :)
…mation output (unit8co#1676) * Support user-defined name in window transformation * Update doc string * Add tests * Review: Test respects the built-in function name --------- Co-authored-by: madtoinou <32447896+madtoinou@users.noreply.github.com> Co-authored-by: Dennis Bader <dennis.bader@gmx.ch>
Summary
As mentioned in the darts' gitter chat, this PR supports a user-defined function name as part of the window transformation output name.
Without this feature, if we provide multiple user-defined functions for the window operations, we have multiple output names such as
rolling_udf_5_target,rolling_udf_5_target_1and etc. This poses the challenge in tracking the derived feature names.Other Information
count_above_mean.